PluginContext#1867
Conversation
This comment has been minimized.
This comment has been minimized.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
RohitKushvaha01
added
the
plugin api
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
bajrangCoder
left a comment
bajrangCoder
left a comment
There was a problem hiding this comment.
LGTM!
But make sure to update plugin docs and api packages accordingly (also plugin template if needed)
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Cordova plugin (pluginContext) that implements token-based access control for Acode plugins. Each plugin receives a unique UUID token associated with permissions declared in their plugin.json file, enabling runtime permission verification.
Changes:
- Created a new Cordova plugin with JavaScript and Android implementations for token-based permission management
- Integrated the plugin into the existing plugin loading system to provide context objects to plugins
- Added plugin configuration files and registered the new plugin in the main package.json
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/pluginContext/www/PluginContext.js | JavaScript module providing the PluginContext API with token generation and permission checking methods |
| src/plugins/pluginContext/src/android/Tee.java | Android implementation managing token lifecycle, permission storage, and validation |
| src/plugins/pluginContext/plugin.xml | Cordova plugin configuration defining the plugin structure and platform bindings |
| src/plugins/pluginContext/package.json | NPM package metadata for the pluginContext Cordova plugin |
| src/lib/loadPlugin.js | Integration point adding context object generation during plugin initialization |
| package.json | Registration of the new plugin in the project's Cordova dependencies |
| .prettierrc | Added empty Prettier configuration file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Also, JSON Plugin Schema needs updation for this change. |
permission: [] is unused currently so not needed for now |
3 participants
Introduces a new Cordova plugin (pluginContext) that provides token-based access control for Acode plugins. Each plugin receives a unique UUID token tied to declared permissions from plugin.json, enabling runtime permission checks via ctx.grantedPermission() and ctx.listAllPermissions().